[
https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821319#comment-16821319
]
Chao Sun edited comment on HDFS-14406 at 4/18/19 5:15 PM:
----------------------------------------------------------
Thanks [~xuel1]. A few comments on patch v5 beside the above mentioned:
1. Why {{addDeferredProcessingTime}} is added in the new patch? in
{{updateMetrics}} it is called even when {{deferredCall}} is false. In
{{updateMetrics}} it is called twice.
2. {{String.format}} is used in {{addProcessingTime}}, which sits in a hot
path. Should we be concerned about the potential performance impact?
3. Like mentioned above, I think we need to implement {{RpcUserMetrics}}
better. It is sharing a fair amount of code with {{RpcDetailedMetrics}}, and
seems having a separate class for this doesn't bring much benefit. Some of the
branchings are not necessary, such as:
{code:java}
if (enableRpcUserMetrics) {
((RpcUserMetrics)rpcDetailedMetrics).shutdown();
}
else {
this.rpcDetailedMetrics.shutdown();
}
{code}
4. Can we put else in the same line as the previous }?
was (Author: csun):
Thanks [~xuel1]. A few comments beside the above mentioned:
1. Why {{addDeferredProcessingTime}} is added in the new patch? in
{{updateMetrics}} it is called even when {{deferredCall}} is false. In
{{updateMetrics}} it is called twice.
2. {{String.format}} is used in {{addProcessingTime}}, which sits in a hot
path. Should we be concerned about the potential performance impact?
3. Like mentioned above, I think we need to implement {{RpcUserMetrics}}
better. It is sharing a fair amount of code with {{RpcDetailedMetrics}}, and
seems having a separate class for this doesn't bring much benefit. Some of the
branchings are not necessary, such as:
{code:java}
if (enableRpcUserMetrics) {
((RpcUserMetrics)rpcDetailedMetrics).shutdown();
}
else {
this.rpcDetailedMetrics.shutdown();
}
{code}
4. Can we put else in the same line as the previous }?
> Add per user RPC Processing time
> --------------------------------
>
> Key: HDFS-14406
> URL: https://issues.apache.org/jira/browse/HDFS-14406
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Xue Liu
> Assignee: Xue Liu
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HDFS-14406.001.patch, HDFS-14406.002.patch,
> HDFS-14406.003.patch, HDFS-14406.004.patch, HDFS-14406.005.patch
>
>
> For a shared cluster we would want to separate users' resources, as well as
> having our metrics reflecting on the usage, latency, etc, for each user.
> This JIRA aims to add per user RPC processing time metrics and expose it via
> JMX.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
