[
https://issues.apache.org/jira/browse/HDDS-1475?focusedWorklogId=236954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236954
]
ASF GitHub Bot logged work on HDDS-1475:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/19 17:18
Start Date: 03/May/19 17:18
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #788:
HDDS-1475 : Fix OzoneContainer start method.
URL: https://github.com/apache/hadoop/pull/788#discussion_r280857665
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -111,6 +111,7 @@ private static long nextCallId() {
private final ReplicationLevel replicationLevel;
private long nodeFailureTimeoutMs;
private final long cacheEntryExpiryInteval;
+ private volatile boolean isStarted = false;
Review comment:
same here too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 236954)
Time Spent: 2h (was: 1h 50m)
> Fix OzoneContainer start method
> -------------------------------
>
> Key: HDDS-1475
> URL: https://issues.apache.org/jira/browse/HDDS-1475
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Bharat Viswanadham
> Assignee: Aravindan Vijayan
> Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In OzoneContainer start() we have
> {code:java}
> startContainerScrub();
> writeChannel.start();
> readChannel.start();
> hddsDispatcher.init();
> hddsDispatcher.setScmId(scmId);{code}
>
> Suppose here if readChannel.start() failed due to some reason, from
> VersionEndPointTask, we try to start OzoneContainer again. This can cause an
> issue for writeChannel.start() if it is already started.
>
> Fix the logic such a way that if service is started, don't attempt to start
> the service again. Similar changes needed to be done for stop().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
