[ https://issues.apache.org/jira/browse/HDDS-1475?focusedWorklogId=237011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237011 ]
ASF GitHub Bot logged work on HDDS-1475: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/May/19 19:06 Start Date: 03/May/19 19:06 Worklog Time Spent: 10m Work Description: avijayanhwx commented on pull request #788: HDDS-1475 : Fix OzoneContainer start method. URL: https://github.com/apache/hadoop/pull/788#discussion_r280894595 ########## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerGrpc.java ########## @@ -69,6 +69,7 @@ private UUID id; private Server server; private final ContainerDispatcher storageContainer; + private volatile boolean isStarted; Review comment: I thought this will be multi-threaded. Given this is single threaded, volatile is not needed. I will remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 237011) Time Spent: 2h 10m (was: 2h) > Fix OzoneContainer start method > ------------------------------- > > Key: HDDS-1475 > URL: https://issues.apache.org/jira/browse/HDDS-1475 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Datanode > Reporter: Bharat Viswanadham > Assignee: Aravindan Vijayan > Priority: Major > Labels: newbie, pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > In OzoneContainer start() we have > {code:java} > startContainerScrub(); > writeChannel.start(); > readChannel.start(); > hddsDispatcher.init(); > hddsDispatcher.setScmId(scmId);{code} > > Suppose here if readChannel.start() failed due to some reason, from > VersionEndPointTask, we try to start OzoneContainer again. This can cause an > issue for writeChannel.start() if it is already started. > > Fix the logic such a way that if service is started, don't attempt to start > the service again. Similar changes needed to be done for stop(). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org