[
https://issues.apache.org/jira/browse/HDFS-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846144#comment-16846144
]
Erik Krogen commented on HDFS-12979:
------------------------------------
Regarding the use of the static variable to pass the tests, it seems kind of
messy, and requires modification in a lot of places. Even if we go with this
approach, can we perhaps add it to {{MiniDFSCluster}} or something to avoid
having to do this step in multiple tests?
That being said, I wonder if we can set some values of
{{DFS_NAMENODE_CHECKPOINT_PERIOD_KEY}} and/or
{{DFS_NAMENODE_CHECKPOINT_TXNS_KEY}} within {{MiniDFSCluster}} to achieve the
same thing without the use of a test-only variable?
Some other smaller comments:
* You have a typo, {{addresString}} instead of {{addressString}}
* I think we can remove the TODO regarding interrupted vs. IO exception
handling?
* Regarding testing, it seems we have a test for the standby being able to
upload to both active and observer. But I think we also need to test for the
case of the Active NN rejecting the request?
> StandbyNode should upload FsImage to ObserverNode after checkpointing.
> ----------------------------------------------------------------------
>
> Key: HDFS-12979
> URL: https://issues.apache.org/jira/browse/HDFS-12979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Konstantin Shvachko
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-12979.001.patch, HDFS-12979.002.patch,
> HDFS-12979.003.patch, HDFS-12979.004.patch, HDFS-12979.005.patch,
> HDFS-12979.006.patch, HDFS-12979.007.patch, HDFS-12979.008.patch
>
>
> ObserverNode does not create checkpoints. So it's fsimage file can get very
> old making bootstrap of ObserverNode too long. A StandbyNode should copy
> latest fsimage to ObserverNode(s) along with ANN.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
