[ https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854490#comment-16854490 ]
Elek, Marton commented on HDDS-1458: ------------------------------------ Thanks the answer [~eyang]. Unfortunately my two concerns are still not addressed (but I may miss sg) TLDR: 1. please use __file__ instead of os.getcwd 2. please don't add any new docker-compose files to the *dist* package (but feel free to move any existing one to an other location inside the dist folder *without* modification. Would you be so kind to address these comments? In more details: (1) Before this patch: {code} #works python -m pytest -s tests/blockade/ #works cd tests/blockade python -m test -s . {code} After this patch: {code} #works python -m pytest -s tests/blockade/ #FAILED cd tests/blockade python -m test -s . {code} As the original version supports more use cases (not just the documented one but other ones which are used during CI/CD) I would prefer to keep the original one. Any anyway: this issue is about "Create a maven profile to run fault injection tests". I think this change is unrelated to this goal (for example this goal can be achieved by my PR without this modification). I tried to check it with symlinks but it worked well. If you can help to reproduce the problem please help and create a separated issue where the problem is clearly specified the steps re defined to reproduce problem. It would be a great help. 2. After the build I can see the new docker-compose files under hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/tests/compose They can't be used in any way from the dist package. Can you please remove them? > Create a maven profile to run fault injection tests > --------------------------------------------------- > > Key: HDDS-1458 > URL: https://issues.apache.org/jira/browse/HDDS-1458 > Project: Hadoop Distributed Data Store > Issue Type: Test > Reporter: Eric Yang > Assignee: Eric Yang > Priority: Major > Labels: pull-request-available > Fix For: 0.4.1 > > Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch, > HDDS-1458.003.patch, HDDS-1458.004.patch, HDDS-1458.005.patch, > HDDS-1458.006.patch, HDDS-1458.007.patch, HDDS-1458.008.patch, > HDDS-1458.009.patch, HDDS-1458.010.patch, HDDS-1458.011.patch, > HDDS-1458.012.patch, HDDS-1458.013.patch, HDDS-1458.014.patch, > HDDS-1458.015.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Some fault injection tests have been written using blockade. It would be > nice to have ability to start docker compose and exercise the blockade test > cases against Ozone docker containers, and generate reports. This is > optional integration tests to catch race conditions and fault tolerance > defects. > We can introduce a profile with id: it (short for integration tests). This > will launch docker compose via maven-exec-plugin and run blockade to simulate > container failures and timeout. > Usage command: > {code} > mvn clean verify -Pit > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org