[
https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855100#comment-16855100
]
Eric Yang commented on HDDS-1458:
---------------------------------
[~elek]
{quote}1. please use _file_ instead of os.getcwd{quote}
Use script to discover dependent file location is a poor design choice. This
type of design has been listed as a [software bugs with significant
consequences|https://en.wikipedia.org/wiki/List_of_software_bugs] in reference
38 and 49. The risk increases overtime when new developers refactor the code
or use a different calling method than originally designed. I have given more
warnings than I should have in this area, and encourage you to put some
thinking to remove this type of coding practice in Ozone code base. Patch 16
uses script location as reference to find docker compose file instead of
current directory.
{quote}2. please don't add any new docker-compose files to the dist
package{quote}
This is fixed in patch 16.
{quote}Can you please also remove this fragment from the
dependencyManagement:{quote}
Patch 16 fixed this issue.
> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
> Key: HDDS-1458
> URL: https://issues.apache.org/jira/browse/HDDS-1458
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch,
> HDDS-1458.003.patch, HDDS-1458.004.patch, HDDS-1458.005.patch,
> HDDS-1458.006.patch, HDDS-1458.007.patch, HDDS-1458.008.patch,
> HDDS-1458.009.patch, HDDS-1458.010.patch, HDDS-1458.011.patch,
> HDDS-1458.012.patch, HDDS-1458.013.patch, HDDS-1458.014.patch,
> HDDS-1458.015.patch, HDDS-1458.016.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some fault injection tests have been written using blockade. It would be
> nice to have ability to start docker compose and exercise the blockade test
> cases against Ozone docker containers, and generate reports. This is
> optional integration tests to catch race conditions and fault tolerance
> defects.
> We can introduce a profile with id: it (short for integration tests). This
> will launch docker compose via maven-exec-plugin and run blockade to simulate
> container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
