[
https://issues.apache.org/jira/browse/HDDS-1635?focusedWorklogId=253740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253740
]
ASF GitHub Bot logged work on HDDS-1635:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 13:33
Start Date: 04/Jun/19 13:33
Worklog Time Spent: 10m
Work Description: elek commented on pull request #894: HDDS-1635.
Maintain docker entrypoint and envtoconf inside ozone project
URL: https://github.com/apache/hadoop/pull/894#discussion_r290297327
##########
File path: hadoop-ozone/dist/src/main/dockerbin/entrypoint.sh
##########
@@ -0,0 +1,138 @@
+#!/usr/bin/env bash
+##
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##
+set -e
+
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+
+if [ -n "$SLEEP_SECONDS" ]; then
+ echo "Sleeping for $SLEEP_SECONDS seconds"
+ sleep $SLEEP_SECONDS
Review comment:
Thanks the comment @eyanghwx
Usually I prefer to avoid significant changes during a move because it won't
be separated from the copy/move:
* It can be harder to follow what has been changed
* And it can be harder to revert in case of any problem
I created an issue to track this problem:
https://issues.apache.org/jira/browse/HDDS-1642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 253740)
Time Spent: 1h 40m (was: 1.5h)
> Maintain docker entrypoint and envtoconf inside ozone project
> -------------------------------------------------------------
>
> Key: HDDS-1635
> URL: https://issues.apache.org/jira/browse/HDDS-1635
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> During an offline discussion with [~eyang] and [~arp], Eric suggested to
> maintain the source of the docker specific start images inside the main ozone
> branch (trunk) instead of the branch of the docker image.
> With this approach the ozone-runner image can be a very lightweight image and
> the entrypoint logic can be versioned together with the ozone itself.
> An other use case is a container creation script. Recently we
> [documented|https://cwiki.apache.org/confluence/display/HADOOP/Ozone+Docker+images]
> that hadoop-runner/ozone-runner/ozone images are not for production (for
> example because they contain development tools).
> We can create a helper tool (similar what Spark provides) to create Ozone
> container images from any production ready base image. But this tool requires
> the existence of the scripts inside the distribution.
> (ps: I think sooner or later the functionality of envtoconf.py can be added
> to the OzoneConfiguration java class and we can parse the configuration
> values directly from environment variables.
> In this patch I copied the required scripts to the ozone source tree and the
> new ozone-runner image (HDDS-1634) is designed to use it from this specific
> location.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
