[
https://issues.apache.org/jira/browse/HDDS-1635?focusedWorklogId=253788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253788
]
ASF GitHub Bot logged work on HDDS-1635:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 14:56
Start Date: 04/Jun/19 14:56
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #894: HDDS-1635.
Maintain docker entrypoint and envtoconf inside ozone project
URL: https://github.com/apache/hadoop/pull/894#issuecomment-498708093
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 34 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| 0 | shelldocs | 1 | Shelldocs was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 588 | trunk passed |
| +1 | compile | 328 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 800 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 203 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 507 | the patch passed |
| +1 | compile | 331 | the patch passed |
| +1 | javac | 331 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| -1 | pylint | 2 | Error running pylint. Please check pylint stderr files. |
| +1 | pylint | 3 | There were no new pylint issues. |
| +1 | shellcheck | 2 | There were no new shellcheck issues. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 680 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 201 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 245 | hadoop-hdds in the patch passed. |
| -1 | unit | 1081 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 74 | The patch does not generate ASF License warnings. |
| | | 5347 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-894/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/894 |
| Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit
compile javac javadoc mvninstall shadedclient pylint |
| uname | Linux 53b193ccd49c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 7991159 |
| Default Java | 1.8.0_212 |
| pylint |
https://builds.apache.org/job/hadoop-multibranch/job/PR-894/2/artifact/out/patch-pylint-stderr.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-894/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-894/2/testReport/ |
| Max. process+thread count | 4667 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/dist U: hadoop-ozone/dist |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-894/2/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 pylint=1.9.2 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 253788)
Time Spent: 1h 50m (was: 1h 40m)
> Maintain docker entrypoint and envtoconf inside ozone project
> -------------------------------------------------------------
>
> Key: HDDS-1635
> URL: https://issues.apache.org/jira/browse/HDDS-1635
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> During an offline discussion with [~eyang] and [~arp], Eric suggested to
> maintain the source of the docker specific start images inside the main ozone
> branch (trunk) instead of the branch of the docker image.
> With this approach the ozone-runner image can be a very lightweight image and
> the entrypoint logic can be versioned together with the ozone itself.
> An other use case is a container creation script. Recently we
> [documented|https://cwiki.apache.org/confluence/display/HADOOP/Ozone+Docker+images]
> that hadoop-runner/ozone-runner/ozone images are not for production (for
> example because they contain development tools).
> We can create a helper tool (similar what Spark provides) to create Ozone
> container images from any production ready base image. But this tool requires
> the existence of the scripts inside the distribution.
> (ps: I think sooner or later the functionality of envtoconf.py can be added
> to the OzoneConfiguration java class and we can parse the configuration
> values directly from environment variables.
> In this patch I copied the required scripts to the ozone source tree and the
> new ozone-runner image (HDDS-1634) is designed to use it from this specific
> location.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
