[
https://issues.apache.org/jira/browse/HDDS-1541?focusedWorklogId=253988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253988
]
ASF GitHub Bot logged work on HDDS-1541:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 19:49
Start Date: 04/Jun/19 19:49
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #885: HDDS-1541.
Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat.
URL: https://github.com/apache/hadoop/pull/885#discussion_r290465238
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -629,6 +638,7 @@ public OzoneOutputStream createKey(
.setType(HddsProtos.ReplicationType.valueOf(type.toString()))
.setFactor(HddsProtos.ReplicationFactor.valueOf(factor.getValue()))
.addAllMetadata(metadata)
+ .setAcls(getAclList())
Review comment:
IMHO default acls list is more sensible as this will add current user and
its group. This makes behavior for default ACLs standard. While parametrized
different users may set it with different approaches. Also this approach is
consistent with how we handle volume and bucket args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 253988)
Time Spent: 81h 20m (was: 81h 10m)
> Implement addAcl,removeAcl,setAcl,getAcl for Key
> -------------------------------------------------
>
> Key: HDDS-1541
> URL: https://issues.apache.org/jira/browse/HDDS-1541
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 81h 20m
> Remaining Estimate: 0h
>
> Implement addAcl,removeAcl,setAcl,getAcl for Key
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
