[ https://issues.apache.org/jira/browse/HDDS-1541?focusedWorklogId=254005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254005 ]
ASF GitHub Bot logged work on HDDS-1541: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Jun/19 20:15 Start Date: 04/Jun/19 20:15 Worklog Time Spent: 10m Work Description: ajayydv commented on pull request #885: HDDS-1541. Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat. URL: https://github.com/apache/hadoop/pull/885#discussion_r290477964 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java ########## @@ -466,26 +486,29 @@ public boolean removeAcl(OzoneObj obj, OzoneAcl acl) throws IOException { throw new OMException("Bucket " + bucket + " is not found", BUCKET_NOT_FOUND); } - List<OzoneAcl> list = bucketInfo.getAcls(); - if (!list.contains(acl)) { - // Return false if acl doesn't exist in current ACLs. - LOG.info("Acl:{} not found in existing ACLs:{}.", acl, - StringUtils.join(",", list)); - return false; + + // When we are removing subset of rights from existing acl. + for(OzoneAcl a: bucketInfo.getAcls()) { + if(a.getName().equals(acl.getName()) && Review comment: Behavior in VolumeManagerImpl is same. We catch the exception thrown from OmOzoneAclMap and then return false. Exception is thrown from OmOzoneAclMap as OmVolumeArgs api's return type is void. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 254005) Time Spent: 82h 10m (was: 82h) > Implement addAcl,removeAcl,setAcl,getAcl for Key > ------------------------------------------------- > > Key: HDDS-1541 > URL: https://issues.apache.org/jira/browse/HDDS-1541 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Labels: pull-request-available > Time Spent: 82h 10m > Remaining Estimate: 0h > > Implement addAcl,removeAcl,setAcl,getAcl for Key -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org