[
https://issues.apache.org/jira/browse/HDFS-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860476#comment-16860476
]
Erik Krogen commented on HDFS-14403:
------------------------------------
Thanks a lot for the review [~csun]. These are all great points! I updated
documentation in {{FairCallQueue.md}}, fixed all of the failing tests, added a
new test case for this within {{TestDecayRpcScheduler}}, and addressed your
comment (3). While adding the new test I realized the configuration wasn't
properly getting passed into {{WeightedTimeCostProvider}}; this is now fixed.
Within {{TestRPC}} to fix the tests, I had to separate the metrics assertions
out of {{testClientBackOffByResponseTime}} and into a new test -- they didn't
seem related to the rest of the test case (looked a bit at the commit history
as well and they were added later on), and because a client which receives a
backoff request will no longer end up in the call volume metrics, it was
failing.
The one thing I didn't yet do is update "count" to "cost"... Want to give you a
chance to do a final review before I make the name change which will inflate
the diff size. All of the above is in the v008 patch.
> Cost-Based RPC FairCallQueue
> ----------------------------
>
> Key: HDFS-14403
> URL: https://issues.apache.org/jira/browse/HDFS-14403
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc, namenode
> Reporter: Erik Krogen
> Assignee: Christopher Gregorian
> Priority: Major
> Labels: qos, rpc
> Attachments: CostBasedFairCallQueueDesign_v0.pdf,
> HDFS-14403.001.patch, HDFS-14403.002.patch, HDFS-14403.003.patch,
> HDFS-14403.004.patch, HDFS-14403.005.patch, HDFS-14403.006.combined.patch,
> HDFS-14403.006.patch, HDFS-14403.007.patch, HDFS-14403.008.patch,
> HDFS-14403.branch-2.8.patch
>
>
> HADOOP-15016 initially described extensions to the Hadoop FairCallQueue
> encompassing both cost-based analysis of incoming RPCs, as well as support
> for reservations of RPC capacity for system/platform users. This JIRA intends
> to track the former, as HADOOP-15016 was repurposed to more specifically
> focus on the reservation portion of the work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
