[
https://issues.apache.org/jira/browse/HDFS-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867976#comment-16867976
]
Chao Sun commented on HDFS-14403:
---------------------------------
Thanks [~xkrogen] for updating the patch. Overall I think it looks good. Some
minor comments:
1. I see that we can associate a namespace with each {{CostProvider}}. Does
that mean we can have different {{CostProvider}} configurations for different
nameservices in a single config, or it is a different thing?
2. Not sure if we should include {{COST}} in the {{Timing}} enum - seems it is
not used anywhere?
3. {{DecayedRpcScheduler#computePriorityLevel}} - should we replace the
parameter {{occurrences}} with something like {{costs}}?
4. {{DecayedRpcScheduler#getAndIncrementCost}} - perhaps {{getAndAddCost}} fits
better for this. Also, I'm not sure if the comment {{@return the value before
incrementation}} is accurate, is it "after"? the returned value is not used
anywhere also.
5. {{DecayedRpcScheduler#parseCostProvider}} - in case there are multiple
{{CostProvider}}s configured, can we log which one is picked?
6. nit: multiple classes contain double blank lines after the import clause. We
should only keep a single line?
> Cost-Based RPC FairCallQueue
> ----------------------------
>
> Key: HDFS-14403
> URL: https://issues.apache.org/jira/browse/HDFS-14403
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc, namenode
> Reporter: Erik Krogen
> Assignee: Christopher Gregorian
> Priority: Major
> Labels: qos, rpc
> Attachments: CostBasedFairCallQueueDesign_v0.pdf,
> HDFS-14403.001.patch, HDFS-14403.002.patch, HDFS-14403.003.patch,
> HDFS-14403.004.patch, HDFS-14403.005.patch, HDFS-14403.006.combined.patch,
> HDFS-14403.006.patch, HDFS-14403.007.patch, HDFS-14403.008.patch,
> HDFS-14403.009.patch, HDFS-14403.branch-2.8.patch
>
>
> HADOOP-15016 initially described extensions to the Hadoop FairCallQueue
> encompassing both cost-based analysis of incoming RPCs, as well as support
> for reservations of RPC capacity for system/platform users. This JIRA intends
> to track the former, as HADOOP-15016 was repurposed to more specifically
> focus on the reservation portion of the work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
