[ 
https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133196#comment-13133196
 ] 

Jitendra Nath Pandey commented on HDFS-2334:
--------------------------------------------

In JournalAndStream#close, stream may already be closed and may be null. You 
probably need to check for null for stream.

                
> Add Closeable to JournalManager
> -------------------------------
>
>                 Key: HDFS-2334
>                 URL: https://issues.apache.org/jira/browse/HDFS-2334
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2334.diff, HDFS-2334.diff
>
>
> A JournalManager may take hold of resources for the duration of their 
> lifetime. This isn't the case at the moment for FileJournalManager, but 
> BookKeeperJournalManager will, and it's conceivable that FileJournalManager 
> could take a lock on a directory etc. 
> This JIRA is to add Closeable to JournalManager so that these resources can 
> be cleaned up when FSEditLog is closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to