[
https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880549#comment-16880549
]
Íñigo Goiri commented on HDFS-14593:
------------------------------------
Some comments on [^HDFS-14593.004.patch]:
* CachedRecordStore#182 should have a space after the if.
* What is the case in CachedRecordStore where the record should be deleted but
then when removing we get false?
* Both new setters in StateStoreService should use {{getTimeDuration()}}.
* For the unit test, I would prefer to wait for some particular state instead
of waiting 5000 ms (checking that the time we waited was smaller than T). We
should also check for the first and second invocation state.
> RBF: Implement deletion feature for expired records in State Store
> ------------------------------------------------------------------
>
> Key: HDFS-14593
> URL: https://issues.apache.org/jira/browse/HDFS-14593
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch,
> HDFS-14593.003.patch, HDFS-14593.004.patch
>
>
> Currently, any router seems to exist in the Router Information eternally.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
