[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880967#comment-16880967 ]
Takanobu Asanuma commented on HDFS-14593: ----------------------------------------- Thanks for your review, [~elgoiri]. Uploaded the 5th patch addressing your comments. It uses {{GenericTestUtils.waitFor()}} for the unit tests. {quote}What is the case in CachedRecordStore where the record should be deleted but then when removing we get false? {quote} If router can't delete the record which should be deleted, router tries to delete the record in the next loadCache. Although I don't think it's a problem, I added a warn log for that case to the latest patch. > RBF: Implement deletion feature for expired records in State Store > ------------------------------------------------------------------ > > Key: HDFS-14593 > URL: https://issues.apache.org/jira/browse/HDFS-14593 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: rbf > Reporter: Takanobu Asanuma > Assignee: Takanobu Asanuma > Priority: Major > Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch, > HDFS-14593.003.patch, HDFS-14593.004.patch, HDFS-14593.005.patch > > > Currently, any router seems to exist in the Router Information eternally. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org