[ 
https://issues.apache.org/jira/browse/HDFS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895732#comment-16895732
 ] 

Siddharth Wagle edited comment on HDFS-2470 at 7/30/19 3:33 AM:
----------------------------------------------------------------

Thanks for the review [~arp]. The code path is covered by many unit tests hence 
did not add any.

Will follow up the patch with rest of the changes and look to add a test 
assertion for the permissions in an appropriate code path.


was (Author: swagle):
Thanks for the review [~arp]. The code path is covered by many unit tests hence 
did not add any.

Will follow up the patch with test rest of the changes and look to add an 
assertion for the permissions in an appropriate code path.

> NN should automatically set permissions on dfs.namenode.*.dir
> -------------------------------------------------------------
>
>                 Key: HDFS-2470
>                 URL: https://issues.apache.org/jira/browse/HDFS-2470
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Siddharth Wagle
>            Priority: Major
>         Attachments: HDFS-2470.01.patch, HDFS-2470.02.patch, 
> HDFS-2470.03.patch
>
>
> Much as the DN currently sets the correct permissions for the 
> dfs.datanode.data.dir, the NN should do the same for the 
> dfs.namenode.(name|edit).dir.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to