[ 
https://issues.apache.org/jira/browse/HDDS-1891?focusedWorklogId=288209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288209
 ]

ASF GitHub Bot logged work on HDDS-1891:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/19 20:02
            Start Date: 02/Aug/19 20:02
    Worklog Time Spent: 10m 
      Work Description: smengcl commented on pull request #1218: HDDS-1891. 
Ozone fs shell command should work with default port when port number is not 
specified
URL: https://github.com/apache/hadoop/pull/1218
 
 
   Tested manually with ozone fs:
   
   ```bash
   $ ozone fs -ls o3fs://bucket.volume.localhost/
   2019-08-02 12:57:13,223 INFO ipc.Client: Retrying connect to server: 
localhost/127.0.0.1:9862. Already tried 0 time(s); retry policy is 
RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)
   ...
   
   $ ozone fs -ls o3fs://bucket.volume.localhost:9861/
   2019-08-02 12:57:21,604 INFO ipc.Client: Retrying connect to server: 
localhost/127.0.0.1:9861. Already tried 0 time(s); retry policy is 
RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)
   ...
   ```
   
   Do we want to add a unit test for this? If yes, existing `TestOzoneShell` 
won't suit the need since `getOmAddress()` always returns the full address with 
port number. And the port number is almost always not default OM port 9862 when 
the running the test. So I might need to come up with a new unit test suite. 
e.g. test the parser only.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 288209)
            Time Spent: 10m
    Remaining Estimate: 0h

> Ozone fs shell command should work with default port when port number is not 
> specified
> --------------------------------------------------------------------------------------
>
>                 Key: HDDS-1891
>                 URL: https://issues.apache.org/jira/browse/HDDS-1891
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:bash|title=Without port number -> Error}
> $ ozone fs -ls o3fs://bucket.volume.localhost/
> -ls: Ozone file system url should be either one of the two forms: 
> o3fs://bucket.volume/key  OR o3fs://bucket.volume.om-host.example.com:5678/key
> ...
> {code}
> {code:bash|title=With port number -> Success}
> $ ozone fs -ls o3fs://bucket.volume.localhost:9862/
> Found 1 items
> -rw-rw-rw-   1 hadoop hadoop       1485 2019-08-01 21:14 
> o3fs://bucket.volume.localhost:9862/README.txt
> {code}
> We expect the first command to attempt port 9862 by default.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to