[ 
https://issues.apache.org/jira/browse/HDDS-1891?focusedWorklogId=291651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291651
 ]

ASF GitHub Bot logged work on HDDS-1891:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Aug/19 23:18
            Start Date: 08/Aug/19 23:18
    Worklog Time Spent: 10m 
      Work Description: smengcl commented on pull request #1218: HDDS-1891. 
Ozone fs shell command should work with default port when port number is not 
specified
URL: https://github.com/apache/hadoop/pull/1218#discussion_r312280716
 
 

 ##########
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##########
 @@ -113,11 +115,14 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
     String omPort = String.valueOf(-1);
     if (!isEmpty(remaining)) {
       String[] parts = remaining.split(":");
-      if (parts.length != 2) {
+      // Array length should only be 1 or 2
+      if (parts.length > 2) {
         throw new IllegalArgumentException(URI_EXCEPTION_TEXT);
 
 Review comment:
   Done. Updated `URI_EXCEPTION_TEXT`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 291651)
    Time Spent: 1h 40m  (was: 1.5h)

> Ozone fs shell command should work with default port when port number is not 
> specified
> --------------------------------------------------------------------------------------
>
>                 Key: HDDS-1891
>                 URL: https://issues.apache.org/jira/browse/HDDS-1891
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> {code:bash|title=Without port number -> Error}
> $ ozone fs -ls o3fs://bucket.volume.localhost/
> -ls: Ozone file system url should be either one of the two forms: 
> o3fs://bucket.volume/key  OR o3fs://bucket.volume.om-host.example.com:5678/key
> ...
> {code}
> {code:bash|title=With port number -> Success}
> $ ozone fs -ls o3fs://bucket.volume.localhost:9862/
> Found 1 items
> -rw-rw-rw-   1 hadoop hadoop       1485 2019-08-01 21:14 
> o3fs://bucket.volume.localhost:9862/README.txt
> {code}
> We expect the first command to attempt port 9862 by default.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to