[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292332 ]
ASF GitHub Bot logged work on HDDS-1913: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Aug/19 23:20 Start Date: 09/Aug/19 23:20 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#discussion_r312674369 ########## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java ########## @@ -388,7 +388,9 @@ public void deleteVolume(String volumeName) throws IOException { @Override public void createBucket(String volumeName, String bucketName) throws IOException { - createBucket(volumeName, bucketName, BucketArgs.newBuilder().build()); + // Set acls of current user. + createBucket(volumeName, bucketName, + BucketArgs.newBuilder().setAcls(getAclList()).build()); Review comment: This will cause creator acls added twice into the final list because the same list will be added again when the passin bucketArgs has a non-empty acl list. {code} List<OzoneAcl> listOfAcls = getAclList(); //ACLs from BucketArgs if(bucketArgs.getAcls() != null) { listOfAcls.addAll(bucketArgs.getAcls()); } {code} The list of acls are not merged properly when using List#addAll, which will be fixed in HDDS-1927. Let's file a separate JIRA for RpcClient#createBucket issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 292332) Time Spent: 1.5h (was: 1h 20m) > Fix OzoneBucket and RpcClient APIS for acl > ------------------------------------------ > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Blocker > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org