[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292390
]
ASF GitHub Bot logged work on HDDS-1913:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/19 02:00
Start Date: 10/Aug/19 02:00
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520109012
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 73 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 10 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 29 | Maven dependency ordering for branch |
| +1 | mvninstall | 602 | trunk passed |
| +1 | compile | 366 | trunk passed |
| +1 | checkstyle | 72 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 983 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 223 | trunk passed |
| 0 | spotbugs | 475 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 708 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 27 | Maven dependency ordering for patch |
| +1 | mvninstall | 643 | the patch passed |
| +1 | compile | 413 | the patch passed |
| +1 | cc | 413 | the patch passed |
| +1 | javac | 413 | the patch passed |
| +1 | checkstyle | 86 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 803 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 198 | the patch passed |
| +1 | findbugs | 707 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 356 | hadoop-hdds in the patch passed. |
| -1 | unit | 2145 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
| | | 8671 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.om.TestKeyManagerImpl |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1257 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux 5dd0fbb2f379 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / ce3c5a3 |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/testReport/ |
| Max. process+thread count | 4909 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/client
hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service
hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 292390)
Time Spent: 2.5h (was: 2h 20m)
> Fix OzoneBucket and RpcClient APIS for acl
> ------------------------------------------
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
