[ https://issues.apache.org/jira/browse/HDFS-11246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914534#comment-16914534 ]
Wei-Chiu Chuang commented on HDFS-11246: ---------------------------------------- bq. Other comments about formats and audit log, I suggest we focus on write log out of Lock, and I would like to file another JIAR to track other issues. What do you think? Thanks again. Make sense to me. Let's get this in soon before it goes stale again. Could you fix the tests? It looks like some are related to this patch: TestCacheAdminCLI {noformat} 2019-08-23 11:18:59,762 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(232)) - Failing tests: 2019-08-23 11:18:59,762 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(233)) - -------------- 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 3: Testing adding a cache pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 4: Testing modifying a cache pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 5: Testing deleting a cache pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 6: Testing listing all cache pools 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 7: Testing listing a single cache pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 8: Testing creating cache paths 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 10: Testing listing directives filtered by pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 11: Testing listing directives filtered by path 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 12: Testing listing directives filtered by path and pool 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 13: Testing removing a directive 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 14: Testing removing every directive for a path 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 15: Testing modifying directives 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 17: Testing listing cache pool statistics 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 18: Testing listing cache directive statistics 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 19: Testing pool max ttl settings 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 20: Testing setting pool unlimited limits 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 21: Testing listing a single cache directive 2019-08-23 11:18:59,763 [Listener at localhost/63473] INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 22: Testing overriding cache pool replication {noformat} > FSNameSystem#logAuditEvent should be called outside the read or write locks > --------------------------------------------------------------------------- > > Key: HDFS-11246 > URL: https://issues.apache.org/jira/browse/HDFS-11246 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.3 > Reporter: Kuhu Shukla > Assignee: He Xiaoqiao > Priority: Major > Attachments: HDFS-11246.001.patch, HDFS-11246.002.patch, > HDFS-11246.003.patch, HDFS-11246.004.patch, HDFS-11246.005.patch, > HDFS-11246.006.patch, HDFS-11246.007.patch, HDFS-11246.008.patch, > HDFS-11246.009.patch, HDFS-11246.010.patch > > > {code} > readLock(); > boolean success = true; > ContentSummary cs; > try { > checkOperation(OperationCategory.READ); > cs = FSDirStatAndListingOp.getContentSummary(dir, src); > } catch (AccessControlException ace) { > success = false; > logAuditEvent(success, operationName, src); > throw ace; > } finally { > readUnlock(operationName); > } > {code} > It would be nice to have audit logging outside the lock esp. in scenarios > where applications hammer a given operation several times. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org