[ https://issues.apache.org/jira/browse/HDFS-11246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919717#comment-16919717 ]
Chao Sun commented on HDFS-11246: --------------------------------- Curious how much perf gain we can get from this. Anyone has done any benchmark? Is there any plan to backport this to branch-2? Thanks. > FSNameSystem#logAuditEvent should be called outside the read or write locks > --------------------------------------------------------------------------- > > Key: HDFS-11246 > URL: https://issues.apache.org/jira/browse/HDFS-11246 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.3 > Reporter: Kuhu Shukla > Assignee: He Xiaoqiao > Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-11246.001.patch, HDFS-11246.002.patch, > HDFS-11246.003.patch, HDFS-11246.004.patch, HDFS-11246.005.patch, > HDFS-11246.006.patch, HDFS-11246.007.patch, HDFS-11246.008.patch, > HDFS-11246.009.patch, HDFS-11246.010.patch, HDFS-11246.011.patch > > > {code} > readLock(); > boolean success = true; > ContentSummary cs; > try { > checkOperation(OperationCategory.READ); > cs = FSDirStatAndListingOp.getContentSummary(dir, src); > } catch (AccessControlException ace) { > success = false; > logAuditEvent(success, operationName, src); > throw ace; > } finally { > readUnlock(operationName); > } > {code} > It would be nice to have audit logging outside the lock esp. in scenarios > where applications hammer a given operation several times. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org