[ https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142656#comment-13142656 ]
Hadoop QA commented on HDFS-2129: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12502036/hdfs-2129.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 23 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestBalancerBandwidth +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1524//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1524//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1524//console This message is automatically generated. > Simplify BlockReader to not inherit from FSInputChecker > ------------------------------------------------------- > > Key: HDFS-2129 > URL: https://issues.apache.org/jira/browse/HDFS-2129 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client, performance > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.24.0 > > Attachments: hdfs-2129-benchmark.png, hdfs-2129.txt, hdfs-2129.txt, > hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt, > seq-read-1gb-bench.png > > > BlockReader is currently quite complicated since it has to conform to the > FSInputChecker inheritance structure. It would be much simpler to implement > it standalone. Benchmarking indicates it's slightly faster, as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira