[
https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142651#comment-13142651
]
Eli Collins commented on HDFS-2129:
-----------------------------------
@Todd, Spectacular!
Patch looks good - comments follow.. otherwise +1
* Make sense to remove BlockReader#read() while we're at it?
* Nit, the TODO in verifyPacketChecksums should be an "NB" right, since we want
to preserve the old behavior (realize this was copied so can change in both
places)
* DBP#countBuffersOfSize doesn't need to have the side effect of removing
buffers
* DBP#returnBuffer needs a javadoc
* Not your change, but please put the return at TestConnCache line 90 on its
own line.
I filed HDFS-2534 to remove the old block reader and config in 24 so we have
the fallback for 23 but don't maintain two copies forever.
> Simplify BlockReader to not inherit from FSInputChecker
> -------------------------------------------------------
>
> Key: HDFS-2129
> URL: https://issues.apache.org/jira/browse/HDFS-2129
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client, performance
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.24.0
>
> Attachments: hdfs-2129-benchmark.png, hdfs-2129.txt, hdfs-2129.txt,
> hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt, hdfs-2129.txt,
> seq-read-1gb-bench.png
>
>
> BlockReader is currently quite complicated since it has to conform to the
> FSInputChecker inheritance structure. It would be much simpler to implement
> it standalone. Benchmarking indicates it's slightly faster, as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
