[ 
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026060#comment-17026060
 ] 

Kihwal Lee commented on HDFS-14758:
-----------------------------------

The hard limit is internally in milliseconds.  However, the config key and the 
description indicate it is in seconds.
{code:java}
+  <property>
+    <name>dfs.namenode.lease-hard-limit-sec</name>
+       <value>1200000</value>
+       <description>
+         Determines the namenode automatic lease recovery interval in seconds.
+       </description>
+  </property>
{code}

I think it is still better to use "seconds" for the config, as users won't need 
to specify it in millisecond granularity.  So the default value here will be 
1200.  Please make {{DfsClientConf}}  convert it from seconds to milliseconds 
when reading the config.


> Decrease lease hard limit
> -------------------------
>
>                 Key: HDFS-14758
>                 URL: https://issues.apache.org/jira/browse/HDFS-14758
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eric Payne
>            Assignee: hemanthboyina
>            Priority: Minor
>         Attachments: HDFS-14758.001.patch, HDFS-14758.002.patch, 
> HDFS-14758.003.patch, HDFS-14758.004.patch
>
>
> The hard limit is currently hard-coded to be 1 hour. This also determines the 
> NN automatic lease recovery interval. Something like 20 min will make more 
> sense.
> After the 5 min soft limit, other clients can recover the lease. If no one 
> else takes the lease away, the original client still can renew the lease 
> within the hard limit. So even after a NN full GC of 8 minutes, leases can be 
> still valid.
> However, there is one risk in reducing the hard limit. E.g. Reduced to 20 
> min. If the NN crashes and the manual failover takes more than 20 minutes, 
> clients will abort.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to