[ 
https://issues.apache.org/jira/browse/HDFS-15167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036013#comment-17036013
 ] 

Ayush Saxena commented on HDFS-15167:
-------------------------------------

The {{resetBlockReportTime}} should be set true only in case of first BR.

In case of manual trigger or for {{diskerror}}, we need not to reset it, 
instead can have the BR triggered normally at its own interval.

We can remove {{resetBlockReportTime}} from {{forceFullBlockReportNow()}} and 
in {{scheduleBlockReport}} if delay is 0(which is only in case of DISK ERROR) 
we need not to set it true.

> Block Report Interval shouldn't be reset apart from first Block Report
> ----------------------------------------------------------------------
>
>                 Key: HDFS-15167
>                 URL: https://issues.apache.org/jira/browse/HDFS-15167
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>
> Presently BlockReport interval is reset even in case the BR is manually 
> triggered or BR is triggered for diskError.
> Which isn't required. As per the comment also, it is intended for first BR 
> only :
> {code:java}
>       // If we have sent the first set of block reports, then wait a random
>       // time before we start the periodic block reports.
>       if (resetBlockReportTime) {
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to