[ https://issues.apache.org/jira/browse/HDFS-15167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037694#comment-17037694 ]
Ayush Saxena commented on HDFS-15167: ------------------------------------- FIxed all the the tests, were failing due to wrong calculation for nextBlockTime, when the multiplication factor comes as 0, so the nextBlockTIme wasn't changing, and {{triggerBlockReportForTests}} relied on it to change to conclude that BR has been sent. Have fixed. {{TestDeadDatanodeDetection}} isn't related. Passes in my local. {noformat} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hdfs.TestDeadNodeDetection [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.141 s - in org.apache.hadoop.hdfs.TestDeadNodeDetection [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 {noformat} [~elgoiri] [~surendralilhore] can you please have a look. > Block Report Interval shouldn't be reset apart from first Block Report > ---------------------------------------------------------------------- > > Key: HDFS-15167 > URL: https://issues.apache.org/jira/browse/HDFS-15167 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ayush Saxena > Assignee: Ayush Saxena > Priority: Major > Attachments: HDFS-15167-01.patch, HDFS-15167-02.patch, > HDFS-15167-03.patch, HDFS-15167-04.patch, HDFS-15167-05.patch > > > Presently BlockReport interval is reset even in case the BR is manually > triggered or BR is triggered for diskError. > Which isn't required. As per the comment also, it is intended for first BR > only : > {code:java} > // If we have sent the first set of block reports, then wait a random > // time before we start the periodic block reports. > if (resetBlockReportTime) { > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org