[
https://issues.apache.org/jira/browse/HDFS-15176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039669#comment-17039669
]
Íñigo Goiri commented on HDFS-15176:
------------------------------------
Let's do a few cosmetic changes:
* Values like {{long observationWindowMs = 60 * 1000}}, make them {{long
observationWindowMs = TimeUnit.MINUTES.toMillis(1)}}.
* Add javadocs in GcTimeMonitorBuilder specially mentioning we set millis in
the values.
* Let's do the values like {{public static final long
DFS_NAMENODE_GC_TIME_MONITOR_SLEEP_INTERVAL_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(5);}}
* When we build the GcTimeMonitorBuilder, let's extract the getTimeDuration()
values.
* In the XML config use 5s instead of 5000 and so on.
> Enable GcTimePercentage Metric in NameNode's JvmMetrics.
> --------------------------------------------------------
>
> Key: HDFS-15176
> URL: https://issues.apache.org/jira/browse/HDFS-15176
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Minor
> Attachments: HDFS-15176.001.patch, HDFS-15176.002.patch,
> HDFS-15176.003.patch
>
>
> The GcTimePercentage(computed by GcTimeMonitor) could be used as a dimension
> to analyze the NameNode GC. We should add a switch config to enable the
> GcTimePercentage metric in HDFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
