[
https://issues.apache.org/jira/browse/HDFS-15176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042631#comment-17042631
]
Ayush Saxena commented on HDFS-15176:
-------------------------------------
Thanx [~LiJinglun] for the patch.
nit :
In the doc, can you surround the configuration names with {{`name`}} to
highlight them as done even for {{rpc context}} metrics.
Like this :
{code:java}
| `GcTimePercentage` | The percentage (0..100) of time that the JVM spent in GC
pauses within the observation window if `dfs.namenode.gc.time.monitor.enable`
is set to true. Use `dfs.namenode.gc.time.monitor.sleep.interval.ms` to specify
the sleep interval in msec. Use
`dfs.namenode.gc.time.monitor.observation.window.ms` to specify the observation
window in msec. |
{code}
Apart LGTM +1
> Enable GcTimePercentage Metric in NameNode's JvmMetrics.
> --------------------------------------------------------
>
> Key: HDFS-15176
> URL: https://issues.apache.org/jira/browse/HDFS-15176
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Minor
> Attachments: HDFS-15176.001.patch, HDFS-15176.002.patch,
> HDFS-15176.003.patch, HDFS-15176.004.patch, HDFS-15176.005.patch
>
>
> The GcTimePercentage(computed by GcTimeMonitor) could be used as a dimension
> to analyze the NameNode GC. We should add a switch config to enable the
> GcTimePercentage metric in HDFS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
