[ https://issues.apache.org/jira/browse/HDFS-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053821#comment-17053821 ]
Hadoop QA commented on HDFS-15209: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 47s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 34s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 40s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 41 unchanged - 0 fixed = 47 total (was 41) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 29s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}123m 45s{color} | {color:red} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 32s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}193m 49s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean | | | hadoop.hdfs.TestLeaseRecovery2 | | | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.7 Server=19.03.7 Image:yetus/hadoop:c44943d1fc3 | | JIRA Issue | HDFS-15209 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12995904/HDFS-15209.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux ec279c42f28d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 4062217 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_242 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/28911/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/28911/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/28911/testReport/ | | Max. process+thread count | 2670 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/28911/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Lease recovery: namenode not able to commitBlockSynchronization if client > comes back and closes the file beforehand > ------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-15209 > URL: https://issues.apache.org/jira/browse/HDFS-15209 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.1.2, 3.1.3 > Reporter: Ye Ni > Assignee: Ye Ni > Priority: Major > Attachments: HDFS-15209.000.patch, HDFS-15209.001.patch > > > We observed a case, client closes the file after soft lease recovery already > started but before namenode commitBlockSynchronization. > This leads to commitBlockSynchronization failure with error below, which > requires either the file isn't closed or the last block isn't in complete > state. > As a result, we will have corrupted replicas by genstamp mismatch, since > datanodes may have finished block recovery with a new genstamp. > This could happen when client delays a lot on write and comes back when lease > recovery already happens by write/append/truncate request from other client. > Repro steps: > # Client #1 finishes writing a file, but hasn't closed yet. > # Client #1 doesn't renew lease for a soft lease period. > # Another client #2 appends the same file. > # Soft lease recovery begins. > # Block recovery in datanodes finishes. > # Client #1 comes back to close the file. > # Close succeeds since Client #1 still hold the lease (lease is revoked as > the last step in soft recovery). > # Namenode tries to commitBlockSynchronization with error log below. > # Namenode and datanodes have different genstamp for this file, resulting in > corrupted block. > Fix: > Check the state of the last block when completing the file. If it's under > recovery, it means lease recovery started, but namenode hasn't > commitBlockSynchronization yet. > In this case, don't complete file. > > {code:java} > 2020-02-22 22:47:04,698 INFO [IPC Server handler 32 on 8020] > org.apache.hadoop.hdfs.server.namenode.FSNamesystem: > commitBlockSynchronization(oldBlock=BP-269461681-10.65.230.22-1554624547020:blk_2642650669_3063725879, > newgenerationstamp=3063765480, newlength=262144000, > newtargets=[25.65.180.47:10010, 25.65.161.162:10010, 100.101.88.162:10010], > closeFile=true, deleteBlock=false) > 2020-02-22 22:47:04,698 DEBUG [IPC Server handler 32 on 8020] > org.apache.hadoop.hdfs.server.namenode.FSNamesystem: Unexpected block > (=BP-269461681-10.65.230.22-1554624547020:blk_2642650669_3063725879) since > the file > (=132269111992796228.data.637180347427616457.tmp.132269136349107823.copying) > is not under construction > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org