[ 
https://issues.apache.org/jira/browse/HDFS-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167809#comment-13167809
 ] 

Doug Cutting commented on HDFS-2660:
------------------------------------

> TestDFSOverAvroRpc uses Writable implementation. Given that the 
> implementation underneath now is moved over to Protobuf [ ... ]

I'm confused by that statement.  Has the WritableRpcEngine API been changed 
incompatibly?  Is it no longer possible to re-implement the abstract methods of 
that API to provide a different RPC transport?  AvroRpcEngine both implements 
that API and uses the Writable implementation of it as a tunnel.  It thus 
provides a good test of the API's plugability.

> I propose removing TestDFSOverAvroRpc.

Please propose that as a separate issue.  Thanks!
                
> Turn off TestDFSOverAvroRpc
> ---------------------------
>
>                 Key: HDFS-2660
>                 URL: https://issues.apache.org/jira/browse/HDFS-2660
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2660.txt
>
>
> With HDFS-2647, protobuf based RPCs are enabled for some of the protocol. 
> With this, Avro RPC based protocol is not working. Avro based RPC needs to be 
> turned on similar to how protobuf based RPCs are done. Until such a time, I 
> propose turning off the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to