[ 
https://issues.apache.org/jira/browse/HDFS-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168012#comment-13168012
 ] 

Suresh Srinivas commented on HDFS-2660:
---------------------------------------

Okay with your patch the protobuf based RPCs are failing.

Before protobuf conversion, the RPC server had protocol and corresponding 
implementation was implementation of that interface. With protobuf, the server 
has been changed to use <Protocol>PB interface. However the implementation that 
is passed is BlockingService (which is does not have the same interface as 
<Protocol>PB). Can Avro work with this?

In order to support Avro, the right way to do it is, change the getServer() 
calls and addProtocol() calls to use WireProtocol and no longer just setting 
the RPC engine. Does RPC engine pluggability mean, just change the RPC engine 
to some other engine and every thing continues work fine?
                
> Turn off TestDFSOverAvroRpc
> ---------------------------
>
>                 Key: HDFS-2660
>                 URL: https://issues.apache.org/jira/browse/HDFS-2660
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2660.patch, HDFS-2660.txt
>
>
> With HDFS-2647, protobuf based RPCs are enabled for some of the protocol. 
> With this, Avro RPC based protocol is not working. Avro based RPC needs to be 
> turned on similar to how protobuf based RPCs are done. Until such a time, I 
> propose turning off the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to