[ https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180695#comment-17180695 ]
Íñigo Goiri commented on HDFS-15535: ------------------------------------ I tend to prefer something like [^HDFS-15535-05.patch] with the class. However, it looks to me like {{RemoteResult}} already does everything you are doing here. As this is parametrized you dont need to cast {code} RemoteResult<RemoteLocation, String> response = rpcClient.invokeSequential(method, locations, String.class, null); RemoteLocation loc= response.getLoc(); result = response.getResult(); result = invokedResult.replaceFirst(loc.getDest(), loc.getSrc()); {code} > RBF: Fix Namespace path to snapshot path resolution for snapshot API > -------------------------------------------------------------------- > > Key: HDFS-15535 > URL: https://issues.apache.org/jira/browse/HDFS-15535 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ayush Saxena > Assignee: Ayush Saxena > Priority: Major > Attachments: HDFS-15535-01.patch, HDFS-15535-02.patch, > HDFS-15535-03.patch, HDFS-15535-04.patch, HDFS-15535-05.patch > > > Presently, after invoking {{createSnapshot}} and {{getSnapshotListing}}, the > namespace path is replaced with mount path. > This presumes as of now that, the invokedLocation shall always be the first > one in the sequence, but there are multiple reasons, where the directory > might not be in the first location. > So, rather than replacing using firstLocation, we should replace path using > actual invoked Location. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org