[ 
https://issues.apache.org/jira/browse/HDFS-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168821#comment-13168821
 ] 

Scott Carey commented on HDFS-2660:
-----------------------------------

{quote}That was the intent. If that's no longer desired, then RPCEngine should 
be removed and protobuf should be used directly. HDFS-2647 and now HDFS-2669 
seem to be assuming that all RPC in HDFS will use protobuf and only protobuf, 
since they're directly specifying protobuf-specifics in e.g., 
NameNodeRpcServer.java. That class used to be generic, indepdendent of any 
particular RPC serialization or transport.
{quote}

It sounds like some modularity would help here.  Perhaps use maven to put the 
protobuf implementation into its own jar (and the avro implementation in its 
own, etc) so that the core jar only contains the generic code and does not have 
protobuf on its classpath.  A user or distribution can select which 
implementation to package and use.

                
> Turn off TestDFSOverAvroRpc
> ---------------------------
>
>                 Key: HDFS-2660
>                 URL: https://issues.apache.org/jira/browse/HDFS-2660
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2660.patch, HDFS-2660.txt
>
>
> With HDFS-2647, protobuf based RPCs are enabled for some of the protocol. 
> With this, Avro RPC based protocol is not working. Avro based RPC needs to be 
> turned on similar to how protobuf based RPCs are done. Until such a time, I 
> propose turning off the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to