[
https://issues.apache.org/jira/browse/HDFS-15940?focusedWorklogId=576540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576540
]
ASF GitHub Bot logged work on HDFS-15940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/21 09:12
Start Date: 04/Apr/21 09:12
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#discussion_r606772623
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery1.java
##########
@@ -336,191 +322,194 @@ public void testFinalizedReplicas () throws IOException
{
if(LOG.isDebugEnabled()) {
LOG.debug("Running " + GenericTestUtils.getMethodName());
}
- ReplicaRecoveryInfo replica1 = new ReplicaRecoveryInfo(BLOCK_ID,
- REPLICA_LEN1, GEN_STAMP-1, ReplicaState.FINALIZED);
- ReplicaRecoveryInfo replica2 = new ReplicaRecoveryInfo(BLOCK_ID,
- REPLICA_LEN1, GEN_STAMP-2, ReplicaState.FINALIZED);
+ ReplicaRecoveryInfo replica1 = new ReplicaRecoveryInfo(BLOCK_ID,
+ REPLICA_LEN1, GEN_STAMP - 1, ReplicaState.FINALIZED);
+ ReplicaRecoveryInfo replica2 = new ReplicaRecoveryInfo(BLOCK_ID,
+ REPLICA_LEN1, GEN_STAMP - 2, ReplicaState.FINALIZED);
Review comment:
May be because you changed the file name and it read it as a new file?
one or two fixes are ok, but in case the PR doesn't induce the checkstyle
and there are plenty. we can let it stay as is, and let the one approving spend
some time, checking that. :-)
Anyway lets ignore for now. I expect the build won't have anything which
would require you any more commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 576540)
Time Spent: 2h 10m (was: 2h)
> Some tests in TestBlockRecovery are consistently failing
> --------------------------------------------------------
>
> Key: HDFS-15940
> URL: https://issues.apache.org/jira/browse/HDFS-15940
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Some long running tests in TestBlockRecovery are consistently failing. Also,
> TestBlockRecovery is huge with so many tests, we should refactor some of long
> running and race condition specific tests to separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
