[
https://issues.apache.org/jira/browse/HDFS-15940?focusedWorklogId=576543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576543
]
ASF GitHub Bot logged work on HDFS-15940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/21 09:22
Start Date: 04/Apr/21 09:22
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#discussion_r606773745
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery1.java
##########
@@ -336,191 +322,194 @@ public void testFinalizedReplicas () throws IOException
{
if(LOG.isDebugEnabled()) {
LOG.debug("Running " + GenericTestUtils.getMethodName());
}
- ReplicaRecoveryInfo replica1 = new ReplicaRecoveryInfo(BLOCK_ID,
- REPLICA_LEN1, GEN_STAMP-1, ReplicaState.FINALIZED);
- ReplicaRecoveryInfo replica2 = new ReplicaRecoveryInfo(BLOCK_ID,
- REPLICA_LEN1, GEN_STAMP-2, ReplicaState.FINALIZED);
+ ReplicaRecoveryInfo replica1 = new ReplicaRecoveryInfo(BLOCK_ID,
+ REPLICA_LEN1, GEN_STAMP - 1, ReplicaState.FINALIZED);
+ ReplicaRecoveryInfo replica2 = new ReplicaRecoveryInfo(BLOCK_ID,
+ REPLICA_LEN1, GEN_STAMP - 2, ReplicaState.FINALIZED);
Review comment:
Oh you are right, maybe QA bot had EOL issues which were not relevant to
actual changes because I renamed the file earlier.
> Anyway lets ignore for now. I expect the build won't have anything which
would require you any more commits
Sure sounds good, I will take care of this going forward. It's the rename
which might let QA bot scan entire file regardless of how minor the actual
change is in that file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 576543)
Time Spent: 2h 20m (was: 2h 10m)
> Some tests in TestBlockRecovery are consistently failing
> --------------------------------------------------------
>
> Key: HDFS-15940
> URL: https://issues.apache.org/jira/browse/HDFS-15940
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Some long running tests in TestBlockRecovery are consistently failing. Also,
> TestBlockRecovery is huge with so many tests, we should refactor some of long
> running and race condition specific tests to separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
