[
https://issues.apache.org/jira/browse/HDFS-16195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409983#comment-17409983
]
Viraj Jasani commented on HDFS-16195:
-------------------------------------
Nice one, 003 patch looks good. Thanks [~preetium].
{quote}Formatter you can refer to - hadoop-format.xml attached above.
{quote}
This attachment definitely looks great reference. [~prasad-acit] I think we
should have this checked-into dev-support as a reference (similar to how HBase
has done
[here|https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml]
and have mentioned in doc as well
[here|https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/developer.adoc#311-code-formatting]).
If you think this is good idea, I can create a Jira for the same. Thank you.
{quote}[~vjasani] could you share the link if the common formatter is available
globally?
{quote}
There is this google-java-format available that some projects use directly (as
one of the standards) [https://github.com/google/google-java-format#eclipse].
Moreover, [~preetium] you can always run this command to get checkstyle output
for specific module and then try to see manually if the output flags any
checkstyle issues in your patch:
{code:java}
mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests{code}
Thanks
> Fix log message when choosing storage groups for block movement in balancer
> ---------------------------------------------------------------------------
>
> Key: HDFS-16195
> URL: https://issues.apache.org/jira/browse/HDFS-16195
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
> Reporter: Preeti
> Priority: Major
> Attachments: HADOOP-16195.001.patch, HADOOP-16195.002.patch,
> HADOOP-16195.003.patch, hadoop-format.xml
>
>
> Correct the log message in line with the logic associated with
> moving blocks in chooseStorageGroups() in the balancer. All log lines should
> indicate from which storage source the blocks are being moved correctly to
> avoid ambiguity. Right now one of the log lines is incorrect:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java#L555]
> which indicates that storage blocks are moved from underUtilized to
> aboveAvgUtilized nodes, while it is actually the other way around in the code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
