[
https://issues.apache.org/jira/browse/HDFS-16195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414924#comment-17414924
]
Ayush Saxena commented on HDFS-16195:
-------------------------------------
Thanx [~preetium] for the patch.
Can you change the log lines to use logger format?
Eg. :
{code:java}
LOG.info("Choosing migration for {} : trying to move data "
+ "from overUtilized nodes to underUtilized nodes",
matcher);
{code}
> Fix log message when choosing storage groups for block movement in balancer
> ---------------------------------------------------------------------------
>
> Key: HDFS-16195
> URL: https://issues.apache.org/jira/browse/HDFS-16195
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
> Reporter: Preeti
> Assignee: Preeti
> Priority: Major
> Attachments: HADOOP-16195.001.patch, HADOOP-16195.002.patch,
> HADOOP-16195.003.patch, hadoop-format.xml
>
>
> Correct the log message in line with the logic associated with
> moving blocks in chooseStorageGroups() in the balancer. All log lines should
> indicate from which storage source the blocks are being moved correctly to
> avoid ambiguity. Right now one of the log lines is incorrect:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java#L555]
> which indicates that storage blocks are moved from underUtilized to
> aboveAvgUtilized nodes, while it is actually the other way around in the code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
