[ https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657301 ]
ASF GitHub Bot logged work on HDFS-16242: ----------------------------------------- Author: ASF GitHub Bot Created on: 29/Sep/21 15:03 Start Date: 29/Sep/21 15:03 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3494: URL: https://github.com/apache/hadoop/pull/3494#issuecomment-930262554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 1m 9s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 12m 35s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 28m 28s | | trunk passed | | +1 :green_heart: | compile | 28m 29s | | trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 | | +1 :green_heart: | compile | 24m 3s | | trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | +1 :green_heart: | checkstyle | 4m 27s | | trunk passed | | +1 :green_heart: | mvnsite | 3m 41s | | trunk passed | | +1 :green_heart: | javadoc | 2m 26s | | trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 | | +1 :green_heart: | javadoc | 3m 32s | | trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | +1 :green_heart: | spotbugs | 7m 32s | | trunk passed | | +1 :green_heart: | shadedclient | 29m 27s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | | the patch passed | | +1 :green_heart: | compile | 27m 45s | | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 | | +1 :green_heart: | javac | 27m 45s | | the patch passed | | +1 :green_heart: | compile | 24m 19s | | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | +1 :green_heart: | javac | 24m 19s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 4m 9s | | the patch passed | | +1 :green_heart: | mvnsite | 3m 13s | | the patch passed | | +1 :green_heart: | javadoc | 2m 8s | | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 | | +1 :green_heart: | javadoc | 3m 33s | | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | +1 :green_heart: | spotbugs | 7m 56s | | the patch passed | | +1 :green_heart: | shadedclient | 27m 27s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 17m 16s | | hadoop-common in the patch passed. | | -1 :x: | unit | 98m 9s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. | | +0 :ok: | asflicense | 0m 47s | | ASF License check generated no output? | | | | 362m 46s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdfs.TestEncryptionZonesWithKMS | | | hadoop.hdfs.TestDecommission | | | hadoop.hdfs.web.TestWebHdfsFileSystemContract | | | hadoop.hdfs.TestReconstructStripedFileWithValidator | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/3494 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux 3f80de784e3f 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 1d4e1b1177fad0d5f720616a7278aa61830088a1 | | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/testReport/ | | Max. process+thread count | 3143 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 657301) Time Spent: 1.5h (was: 1h 20m) > JournalMetrics should add JournalId MetricTag to distinguish different > nameservice journal metrics. > ---------------------------------------------------------------------------------------------------- > > Key: HDFS-16242 > URL: https://issues.apache.org/jira/browse/HDFS-16242 > Project: Hadoop HDFS > Issue Type: Improvement > Components: journal-node > Affects Versions: 3.4.0 > Reporter: Max Xie > Priority: Minor > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > JournalMetrics should add JournalId MetricTag to distinguish different > nameservice journal metrics when JournalNode use ganglia sink or prometheus > sink. > *JMX* > Before this patch, journal' jmx : > {code:java} > // jmx json > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest1", > "Syncs60sNumOps" : 0, > ... > }, > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", > "Syncs60sNumOps" : 0, > ... > } > {code} > > After this patch, journal' jmx : > > {code:java} > // jmx json > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest1", > "tag.JournalId" : "nntest1", // add this tag > "Syncs60sNumOps" : 0, > ... > }, > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", > "tag.JournalId" : "nntest2", > "Syncs60sNumOps" : 0, > ... > } > {code} > > *PrometheusSink* > Before this patch, journal' prometheus export : > > {code:java} > journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2 > {code} > After this patch, journal' prometheus export : > {code:java} > journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"} > 2 > journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"} > 75 > {code} > > > > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org