[ https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657755 ]
ASF GitHub Bot logged work on HDFS-16242: ----------------------------------------- Author: ASF GitHub Bot Created on: 30/Sep/21 00:22 Start Date: 30/Sep/21 00:22 Worklog Time Spent: 10m Work Description: adamantal commented on a change in pull request #3494: URL: https://github.com/apache/hadoop/pull/3494#discussion_r718248005 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java ########## @@ -281,7 +300,6 @@ public void testJournal() throws Exception { } - @Test(timeout=100000) Review comment: Could you please readd the line here? ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java ########## @@ -99,6 +100,11 @@ String getName() { return "Journal-" + journal.getJournalId(); } + @Metric(value={"JournalId", "Current JournalId"}, type= Type.TAG) Review comment: ```suggestion @Metric(value={"JournalId", "Current JournalId"}, type=Type.TAG) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 657755) Time Spent: 1h 50m (was: 1h 40m) > JournalMetrics should add JournalId MetricTag to distinguish different > nameservice journal metrics. > ---------------------------------------------------------------------------------------------------- > > Key: HDFS-16242 > URL: https://issues.apache.org/jira/browse/HDFS-16242 > Project: Hadoop HDFS > Issue Type: Improvement > Components: journal-node > Affects Versions: 3.4.0 > Reporter: Max Xie > Priority: Minor > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > JournalMetrics should add JournalId MetricTag to distinguish different > nameservice journal metrics when JournalNode use ganglia sink or prometheus > sink. > *JMX* > Before this patch, journal' jmx : > {code:java} > // jmx json > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest1", > "Syncs60sNumOps" : 0, > ... > }, > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", > "Syncs60sNumOps" : 0, > ... > } > {code} > > After this patch, journal' jmx : > > {code:java} > // jmx json > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest1", > "tag.JournalId" : "nntest1", // add this tag > "Syncs60sNumOps" : 0, > ... > }, > { > "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", > "tag.JournalId" : "nntest2", > "Syncs60sNumOps" : 0, > ... > } > {code} > > *PrometheusSink* > Before this patch, journal' prometheus export : > > {code:java} > journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2 > {code} > After this patch, journal' prometheus export : > {code:java} > journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"} > 2 > journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"} > 75 > {code} > > > > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org