[
https://issues.apache.org/jira/browse/HDFS-16260?focusedWorklogId=663629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663629
]
ASF GitHub Bot logged work on HDFS-16260:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/21 16:10
Start Date: 11/Oct/21 16:10
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on a change in pull request
#3532:
URL: https://github.com/apache/hadoop/pull/3532#discussion_r726272359
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs_deleteSnapshot.cc
##########
@@ -1,87 +0,0 @@
-/*
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-*/
-
-#include <google/protobuf/stubs/common.h>
-#include <unistd.h>
-#include "tools_common.h"
-
-void usage(){
- std::cout << "Usage: hdfs_deleteSnapshot [OPTION] PATH NAME"
- << std::endl
- << std::endl << "Delete a snapshot NAME from a snapshottable directory."
- << std::endl << "This operation requires owner privilege of the
snapshottable directory."
- << std::endl
- << std::endl << " -h display this help and exit"
- << std::endl
- << std::endl << "Examples:"
- << std::endl << "hdfs_deleteSnapshot
hdfs://localhost.localdomain:8020/dir mySnapshot"
- << std::endl << "hdfs_deleteSnapshot /dir1/dir2 mySnapshot"
- << std::endl;
-}
-
-int main(int argc, char *argv[]) {
- //We should have at least 2 arguments
- if (argc < 2) {
- usage();
- exit(EXIT_FAILURE);
- }
-
- int input;
-
- //Using GetOpt to read in the values
- opterr = 0;
- while ((input = getopt(argc, argv, "h")) != -1) {
Review comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 663629)
Time Spent: 1h 50m (was: 1h 40m)
> Make hdfs_deleteSnapshot tool cross platform
> --------------------------------------------
>
> Key: HDFS-16260
> URL: https://issues.apache.org/jira/browse/HDFS-16260
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client, libhdfs++, tools
> Affects Versions: 3.4.0
> Environment: Centos 7, Centos 8, Debian 10, Ubuntu Focal
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The source files for hdfs_deleteSnapshot uses *getopt* for parsing the
> command line arguments. getopt is available only on Linux and thus, isn't
> cross platform. We need to replace getopt with *boost::program_options* to
> make this cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
