[ https://issues.apache.org/jira/browse/HDFS-16283?focusedWorklogId=671838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671838 ]
ASF GitHub Bot logged work on HDFS-16283: ----------------------------------------- Author: ASF GitHub Bot Created on: 29/Oct/21 06:31 Start Date: 29/Oct/21 06:31 Worklog Time Spent: 10m Work Description: Hexiaoqiao commented on pull request #3595: URL: https://github.com/apache/hadoop/pull/3595#issuecomment-954466025 Thanks for bringing this improvement. Sorry I do not receive discussion in mail-list and reply here directly. I am not sure if it is the best solution to expose namespace id to client which will confuse the end-user in my opinion. `If we are adding new protocols, maybe we can add "renewLease(String clientName, String path)" and let Router do the resolve from path to namespace.` In my practice, I think `path` will be the good choice here. Strong +1. And router could resolve it which keep the same logic for other interface. But the bad news is that it will increase the invoke interface times. Anyway, I think this solution will not break anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 671838) Time Spent: 50m (was: 40m) > RBF: improve renewLease() to call only a specific NameNode rather than make > fan-out calls > ----------------------------------------------------------------------------------------- > > Key: HDFS-16283 > URL: https://issues.apache.org/jira/browse/HDFS-16283 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: rbf > Reporter: Aihua Xu > Assignee: Aihua Xu > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Currently renewLease() against a router will make fan-out to all the > NameNodes. Since renewLease() call is so frequent and if one of the NameNodes > are slow, then eventually the router queues are blocked by all renewLease() > and cause router degradation. > We will make a change in the client side to keep track of NameNode Id in > additional to current fileId so routers understand which NameNodes the client > is renewing lease against. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org