[
https://issues.apache.org/jira/browse/HDFS-16283?focusedWorklogId=675830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675830
]
ASF GitHub Bot logged work on HDFS-16283:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:32
Start Date: 04/Nov/21 01:32
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3595:
URL: https://github.com/apache/hadoop/pull/3595#discussion_r742199623
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
##########
@@ -765,6 +765,14 @@ BatchedDirectoryListing getBatchedListing(
@Idempotent
void renewLease(String clientName) throws IOException;
+ /**
+ * The functionality is the same as renewLease(clientName). This is to
support
+ * router based FileSystem to newLease against a specific target FileSystem
instead
+ * of all the target FileSystems in each call.
+ */
+ @Idempotent
+ void renewLease(String clientName, String nsId) throws IOException;
Review comment:
That's a good point.
ClientProtocol shouldn't care about subclusters.
The whole abstraction is based on paths and that would make more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 675830)
Time Spent: 2h 10m (was: 2h)
> RBF: improve renewLease() to call only a specific NameNode rather than make
> fan-out calls
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-16283
> URL: https://issues.apache.org/jira/browse/HDFS-16283
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Aihua Xu
> Assignee: Aihua Xu
> Priority: Major
> Labels: pull-request-available
> Attachments: RBF_ improve renewLease() to call only a specific
> NameNode rather than make fan-out calls.pdf
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently renewLease() against a router will make fan-out to all the
> NameNodes. Since renewLease() call is so frequent and if one of the NameNodes
> are slow, then eventually the router queues are blocked by all renewLease()
> and cause router degradation.
> We will make a change in the client side to keep track of NameNode Id in
> additional to current fileId so routers understand which NameNodes the client
> is renewing lease against.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
