[
https://issues.apache.org/jira/browse/HDFS-16359?focusedWorklogId=688203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688203
]
ASF GitHub Bot logged work on HDFS-16359:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 17:59
Start Date: 30/Nov/21 17:59
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3731:
URL: https://github.com/apache/hadoop/pull/3731#discussion_r759530486
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
##########
@@ -726,9 +726,10 @@ static String getMethodName() {
* @return List of name spaces in the federation on
* removing the already invoked namespaceinfo.
*/
- private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
+ private Set<FederationNamespaceInfo> getNameSpaceInfo(
Review comment:
I don't think this is too important to be honest.
There might be some minor optimization by being static but I do not think it
is that important.
The main reason to make it static would be to make clear that this method is
not doing anything with the attributes of the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 688203)
Time Spent: 2h 20m (was: 2h 10m)
> RBF: RouterRpcServer#invokeAtAvailableNs does not take effect when retrying
> ---------------------------------------------------------------------------
>
> Key: HDFS-16359
> URL: https://issues.apache.org/jira/browse/HDFS-16359
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> RouterRpcServer#invokeAtAvailableNs does not take effect when retrying. See
> HDFS-15543.
> The original code of RouterRpcServer#getNameSpaceInfo looks like this:
> {code:java}
> private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
> Set<FederationNamespaceInfo> namespaceInfos = new HashSet<>();
> for (FederationNamespaceInfo ns : namespaceInfos) {
> if (!nsId.equals(ns.getNameserviceId())) {
> namespaceInfos.add(ns);
> }
> }
> return namespaceInfos;
> } {code}
> And _namespaceInfos_ is always empty here.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
