[
https://issues.apache.org/jira/browse/HDFS-16359?focusedWorklogId=688204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688204
]
ASF GitHub Bot logged work on HDFS-16359:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 18:00
Start Date: 30/Nov/21 18:00
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3731:
URL: https://github.com/apache/hadoop/pull/3731#discussion_r759531237
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
##########
@@ -726,9 +726,10 @@ static String getMethodName() {
* @return List of name spaces in the federation on
* removing the already invoked namespaceinfo.
*/
- private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
+ private Set<FederationNamespaceInfo> getNameSpaceInfo(
Review comment:
BTW, if we are changing the signature of the method, I would also add
final to the arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 688204)
Time Spent: 2.5h (was: 2h 20m)
> RBF: RouterRpcServer#invokeAtAvailableNs does not take effect when retrying
> ---------------------------------------------------------------------------
>
> Key: HDFS-16359
> URL: https://issues.apache.org/jira/browse/HDFS-16359
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> RouterRpcServer#invokeAtAvailableNs does not take effect when retrying. See
> HDFS-15543.
> The original code of RouterRpcServer#getNameSpaceInfo looks like this:
> {code:java}
> private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
> Set<FederationNamespaceInfo> namespaceInfos = new HashSet<>();
> for (FederationNamespaceInfo ns : namespaceInfos) {
> if (!nsId.equals(ns.getNameserviceId())) {
> namespaceInfos.add(ns);
> }
> }
> return namespaceInfos;
> } {code}
> And _namespaceInfos_ is always empty here.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
