[
https://issues.apache.org/jira/browse/HDFS-16402?focusedWorklogId=705882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705882
]
ASF GitHub Bot logged work on HDFS-16402:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/22 06:10
Start Date: 10/Jan/22 06:10
Worklog Time Spent: 10m
Work Description: tomscut commented on pull request #3839:
URL: https://github.com/apache/hadoop/pull/3839#issuecomment-1008568017
> Thanks @tomscut for your information. It makes sense to me. I concerned
why [HDFS-14042](https://issues.apache.org/jira/browse/HDFS-14042) not fix
completely, any other corner case?
Thanks @Hexiaoqiao for your comments. NPE has been fixed by
[HDFS-14042](https://issues.apache.org/jira/browse/HDFS-14042). IMO, it is a
safer way to keep these two operations (`stats.subtract() `and `stats.add()`)
transactional in case of any other potential exceptions. What do you think of
this? This has no effect on the original logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 705882)
Time Spent: 1h 10m (was: 1h)
> HeartbeatManager may cause incorrect stats
> ------------------------------------------
>
> Key: HDFS-16402
> URL: https://issues.apache.org/jira/browse/HDFS-16402
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2021-12-29-08-25-44-303.png,
> image-2021-12-29-08-25-54-441.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> After reconfig {*}dfs.datanode.data.dir{*}, we found that the stats of the
> Namenode Web became *negative* and there were many NPE in namenode logs. This
> problem has been solved by HDFS-14042.
> !image-2021-12-29-08-25-54-441.png|width=681,height=293!
> !image-2021-12-29-08-25-44-303.png|width=677,height=180!
> However, if *HeartbeatManager#updateHeartbeat* and
> *HeartbeatManager#updateLifeline* throw other exceptions, stats errors can
> also occur. We should ensure that *stats.subtract()* and *stats.add()* are
> transactional.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
