[ https://issues.apache.org/jira/browse/HDFS-16402?focusedWorklogId=713423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713423 ]
ASF GitHub Bot logged work on HDFS-16402: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Jan/22 22:48 Start Date: 23/Jan/22 22:48 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3839: URL: https://github.com/apache/hadoop/pull/3839#issuecomment-1019583687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 25m 36s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 24m 51s | | trunk passed | | +1 :green_heart: | compile | 1m 33s | | trunk passed | | +1 :green_heart: | checkstyle | 1m 11s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 37s | | trunk passed | | +1 :green_heart: | javadoc | 1m 41s | | trunk passed | | +1 :green_heart: | spotbugs | 3m 37s | | trunk passed | | +1 :green_heart: | shadedclient | 25m 44s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 22s | | the patch passed | | +1 :green_heart: | compile | 1m 21s | | the patch passed | | +1 :green_heart: | javac | 1m 21s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 59s | | the patch passed | | +1 :green_heart: | mvnsite | 1m 25s | | the patch passed | | +1 :green_heart: | javadoc | 1m 28s | | the patch passed | | +1 :green_heart: | spotbugs | 3m 31s | | the patch passed | | +1 :green_heart: | shadedclient | 25m 9s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 312m 55s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 56s | | The patch does not generate ASF License warnings. | | | | 431m 43s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3839/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/3839 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux 9e7444c79a7d 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 5e4c319d96e688d5a307473babe1e7dcd66e3616 | | Default Java | Red Hat, Inc.-1.8.0_312-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3839/4/testReport/ | | Max. process+thread count | 2053 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3839/4/console | | versions | git=2.27.0 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 713423) Time Spent: 2h 40m (was: 2.5h) > HeartbeatManager may cause incorrect stats > ------------------------------------------ > > Key: HDFS-16402 > URL: https://issues.apache.org/jira/browse/HDFS-16402 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: tomscut > Assignee: tomscut > Priority: Major > Labels: pull-request-available > Attachments: image-2021-12-29-08-25-44-303.png, > image-2021-12-29-08-25-54-441.png > > Time Spent: 2h 40m > Remaining Estimate: 0h > > After reconfig {*}dfs.datanode.data.dir{*}, we found that the stats of the > Namenode Web became *negative* and there were many NPE in namenode logs. This > problem has been solved by HDFS-14042. > !image-2021-12-29-08-25-54-441.png|width=681,height=293! > !image-2021-12-29-08-25-44-303.png|width=677,height=180! > However, if *HeartbeatManager#updateHeartbeat* and > *HeartbeatManager#updateLifeline* throw other exceptions, stats errors can > also occur. We should ensure that *stats.subtract()* and *stats.add()* are > transactional. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org