[ https://issues.apache.org/jira/browse/HDFS-16503?focusedWorklogId=740705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-740705 ]
ASF GitHub Bot logged work on HDFS-16503: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Mar/22 08:18 Start Date: 14/Mar/22 08:18 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #4067: URL: https://github.com/apache/hadoop/pull/4067#issuecomment-1066495941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 35s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 12m 41s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 23m 11s | | trunk passed | | +1 :green_heart: | compile | 5m 54s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | compile | 5m 36s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 15s | | trunk passed | | +1 :green_heart: | mvnsite | 3m 13s | | trunk passed | | +1 :green_heart: | javadoc | 2m 29s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 3m 11s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 6m 58s | | trunk passed | | +1 :green_heart: | shadedclient | 20m 23s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 43s | | the patch passed | | +1 :green_heart: | compile | 5m 44s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javac | 5m 44s | | the patch passed | | +1 :green_heart: | compile | 5m 22s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 5m 22s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 1m 5s | | the patch passed | | +1 :green_heart: | mvnsite | 2m 49s | | the patch passed | | +1 :green_heart: | javadoc | 2m 2s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 2m 47s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 7m 9s | | the patch passed | | +1 :green_heart: | shadedclient | 20m 41s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 22s | | hadoop-hdfs-client in the patch passed. | | +1 :green_heart: | unit | 229m 18s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | unit | 22m 18s | | hadoop-hdfs-rbf in the patch passed. | | +1 :green_heart: | asflicense | 0m 44s | | The patch does not generate ASF License warnings. | | | | 393m 1s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4067/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4067 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux 119c40a380b8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / c4587e795a439ed563a824084bf5312765fc0ea3 | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4067/1/testReport/ | | Max. process+thread count | 3109 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4067/1/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 740705) Time Spent: 20m (was: 10m) > Should verify whether the path name is valid in the WebHDFS > ----------------------------------------------------------- > > Key: HDFS-16503 > URL: https://issues.apache.org/jira/browse/HDFS-16503 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: tomscut > Assignee: tomscut > Priority: Major > Labels: pull-request-available > Attachments: image-2022-03-14-09-35-49-860.png > > Time Spent: 20m > Remaining Estimate: 0h > > When creating a file using WebHDFS, there are two main steps: > 1. Obtain the location of the Datanode to be written. > 2. Put the file to this location. > Currently *NameNodeRpcServer* verifies that pathName is valid, but > *NamenodeWebHdfsMethods* and *RouterWebHdfsMethods* do not. > So if we use an invalid path(such as duplicated slash), the first step > returns success, but the second step throws an {*}InvalidPathException{*}. > IMO, we should also do the validation in WebHdfs, which is consistent with > the NameNodeRpcServer. > !image-2022-03-14-09-35-49-860.png|width=548,height=164! > The same webHDFS operations are: CREATE, APPEND, OPEN, GETFILECHECKSUM. So we > can add DFSUtil.isValidName to redirectURI for *NamenodeWebHdfsMethods* and > *RouterWebHdfsMethods.* -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org