[
https://issues.apache.org/jira/browse/HDFS-16503?focusedWorklogId=741487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741487
]
ASF GitHub Bot logged work on HDFS-16503:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/22 08:31
Start Date: 15/Mar/22 08:31
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #4067:
URL: https://github.com/apache/hadoop/pull/4067#discussion_r826700932
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
##########
@@ -478,7 +478,7 @@ private Path makeAbsolute(Path f) {
return f.isAbsolute()? f: new Path(workingDir, f);
}
- static Map<?, ?> jsonParse(final HttpURLConnection c,
+ public static Map<?, ?> jsonParse(final HttpURLConnection c,
final boolean useErrorStream) throws IOException {
Review comment:
Is it made public only for test?
If so please add VisibleForTesting Annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 741487)
Time Spent: 1h 10m (was: 1h)
> Should verify whether the path name is valid in the WebHDFS
> -----------------------------------------------------------
>
> Key: HDFS-16503
> URL: https://issues.apache.org/jira/browse/HDFS-16503
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2022-03-14-09-35-49-860.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When creating a file using WebHDFS, there are two main steps:
> 1. Obtain the location of the Datanode to be written.
> 2. Put the file to this location.
> Currently *NameNodeRpcServer* verifies that pathName is valid, but
> *NamenodeWebHdfsMethods* and *RouterWebHdfsMethods* do not.
> So if we use an invalid path(such as duplicated slash), the first step
> returns success, but the second step throws an {*}InvalidPathException{*}.
> IMO, we should also do the validation in WebHdfs, which is consistent with
> the NameNodeRpcServer.
> !image-2022-03-14-09-35-49-860.png|width=548,height=164!
> The same webHDFS operations are: CREATE, APPEND, OPEN, GETFILECHECKSUM. So we
> can add DFSUtil.isValidName to redirectURI for *NamenodeWebHdfsMethods* and
> *RouterWebHdfsMethods.*
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
