[
https://issues.apache.org/jira/browse/HDFS-16457?focusedWorklogId=752092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752092
]
ASF GitHub Bot logged work on HDFS-16457:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 04:13
Start Date: 04/Apr/22 04:13
Worklog Time Spent: 10m
Work Description: singer-bin commented on code in PR #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r841353288
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java:
##########
@@ -756,4 +759,33 @@ public void testDfsUsageParameters() throws
ReconfigurationException {
}
}
}
+
+ public static class DummyCachingGetSpaceUsed extends CachingGetSpaceUsed {
+ public DummyCachingGetSpaceUsed(Builder builder) throws IOException {
+ super(builder.setInterval(1000).setJitter(0L));
+ }
+
+ @Override
+ protected void refresh() {
+ counter++;
+ }
+ }
+
+ @Test
+ public void testDfsUsageKlass() throws IOException, ReconfigurationException,
+ InterruptedException {
+
+ long lastCounter = counter;
+ Thread.sleep(5000);
+ assertTrue(counter > lastCounter);
+
+ for (int i = 0; i < NUM_DATA_NODE; i++) {
+ DataNode dn = cluster.getDataNodes().get(i);
+ dn.reconfigurePropertyImpl(FS_GETSPACEUSED_CLASSNAME, null);
+ }
+
+ lastCounter = counter;
+ Thread.sleep(5000);
+ assertEquals(lastCounter, counter);
+ }
Review Comment:
Thank you very much for your comment, I will consider it. @tasanuma
Issue Time Tracking
-------------------
Worklog Id: (was: 752092)
Time Spent: 4h 10m (was: 4h)
> Make fs.getspaceused.classname reconfigurable
> ---------------------------------------------
>
> Key: HDFS-16457
> URL: https://issues.apache.org/jira/browse/HDFS-16457
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.3.0
> Reporter: yanbin.zhang
> Assignee: yanbin.zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Now if we want to switch fs.getspaceused.classname we need to restart the
> NameNode. It would be convenient if we can switch it at runtime.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
